search

andrewtimberlake / sham

An Elixir mock HTTP(S) server useful for testing HTTP(S) clients.
MIT License
3 stars 1 forks source link

Support for Bandit? #1

Closed warmwaffles closed 3 days ago

warmwaffles commented 1 week ago

I see that plug cowboy is used, do you have plans to support Bandit as an optional underlying http(s) server? I'm looking to replace Bypass and this seems super promising.

andrewtimberlake commented 1 week ago

Not yet. Is there a reason using Bandit would be advantageous?

warmwaffles commented 6 days ago

Other than the fact I don't have to pull down cowboy and use ranch. Currently fighting with upgrading ranch and other dependencies relying on it being at a specific version. This would be one less thing. But no worries.

andrewtimberlake commented 6 days ago

I’ll have a look at what it might take to support both

warmwaffles commented 4 days ago

It's not super critical, just a passing thought. I'll close this.

andrewtimberlake commented 3 days ago

Hi @warmwaffles I’ve added support for Bandit I’ve tested that the optional server works on projects I have that use Plug.Cowboy Please test that it works on your non cowboy project.

warmwaffles commented 3 days ago

Awesome, I'll take a look

warmwaffles commented 3 days ago

Yea @andrewtimberlake this works like a charm. Thanks a ton!