andrewvasilchuk / vue-accessible-select

Vue.js component for accessible selects
MIT License
15 stars 5 forks source link

Fix keyboard navigation #14

Open jonasclement opened 2 years ago

jonasclement commented 2 years ago

Hello.

I noticed that this library has a few flaws regarding keyboard accessibility, and I've done my best to fix them here :)

Fixed issues:

jonasclement commented 2 years ago

Hello,

I added a few more commits with some additional fixes:

andrewvasilchuk commented 2 years ago

@jonasclement thanks for your PR. I'm investigating your changes.

andrewvasilchuk commented 2 years ago

@jonasclement This one still does not work for me.

Would always select the first matching option, rather than the next matching option, like a native select would.

Don't you mind if I also contribute to your PR?

jonasclement commented 2 years ago

Hmm, no, I see that that doesn't work - I'm sure I fixed it at some point!

You're welcome contribute as you like. I'm going to look into the issue now, and hopefully push a working fix :)

jonasclement commented 2 years ago

Check out a4d6bb95d88c3c0911ddcf2672322faa4235495f - should be working as expected now :)

jonasclement commented 2 years ago

Hey mate - any progress on this? :)