Vue 3 support - Githubissues

andreww2012 commented 1 year ago

Hello, thank you for this great component. I've been using it extensively in my projects and due to the need of having it available in Vue 3, here is my rewrite of it to support Vue 3.

Noteworthy changes:

The component itself and the demo are now written as SFC in composition API style;
Vitest is now used instead Jest for testing;
Vite is used for the demo and bundling for NPM;
test NPM script now runs prettier, type checking and unit testing;
Dependencies upgraded to newer versions.

vue-lazy-youtube-video.min.js is bundled in two phases because JS from Vue's SFC is not touched by TypeScript, but originally the compilation target was set to es5, and I tried to meet this requirement.

andrewvasilchuk commented 1 year ago

@andreww2012 amazing :exploding_head:! Thanks a ton for your contribution. I will review it in 2-3 days.

andreww2012 commented 1 year ago

Hey @andrewvasilchuk any chance you review this one? 🙏

andrewvasilchuk / vue-lazy-youtube-video

Vue 3 support #58