Getting this error in Safari, but other browsers work fine.

delta0800 commented 4 years ago

andrewvasilchuk commented 4 years ago

@delta0800, Thanks. I have researched a little but haven't find out a proper solution 😢. But your issue gave me the idea of creating a prop named iframeAttributes, which will apply the value of that prop to the <iframe /> element, so we can set any <iframe /> attribute we want.

andrewvasilchuk commented 4 years ago

Added ability so set custom <iframe /> attributes: 1ee83c4492740c83f4b895cf3f5cfbaf62b6c515. I am going to release a new minor version ASAP.

delta0800 commented 4 years ago

Hi Andrew,

How are you? Thanks for the quick response and effort. I will give a try later to resolve the iframe issue.

Have a nice day.

Thanks Lawrence

Sent from my iPhone

On 8 Dec 2019, at 19:49, Andrew notifications@github.com wrote:

Added ability so set custom attributes: 1ee83c4. I am going to release a new minor version ASAP.</p> <p>— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/andrewvasilchuk"><img src="https://avatars.githubusercontent.com/u/44983823?v=4" />andrewvasilchuk</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>@delta0800, I have noticed that YouTube gives you an <code><iframe /></code> element which have attribute <code>allow</code>, set to <code>accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture</code>. I have also updated the value of the <code>allow</code> attribute to match the YouTube version. See 9c2e4ceaad4742819bbb79d834db679be935bcef.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/delta0800"><img src="https://avatars.githubusercontent.com/u/53184778?v=4" />delta0800</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Hello Andrew, </p> <p>I saw that the new update with the allow attribute same as YouTube. Last night I tried to run npm update for the package somehow it still the old version contents. But I checked in package.json Have updated to 1.2.2 Any advise? Please correct me if any silly mistakes I have made. Hope I can learn more from you. </p> <p>Thanks Lawrence </p> <p>Sent from my iPhone</p> <blockquote> <p>On 9 Dec 2019, at 04:33, Andrew <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> @delta0800, I have noticed that YouTube gives you an <iframe /> element which have attribute allow, set to accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture. I have also updated the value of the allow attribute to match the YouTube version. See 9c2e4ce.</p> <p>— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/andrewvasilchuk"><img src="https://avatars.githubusercontent.com/u/44983823?v=4" />andrewvasilchuk</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>@delta0800, I have released a beta version. It's being tested right now, becaise as for now I am not sure it's stable. You can install a beta version running this command:</p> <pre><code class="language-bash">npm i vue-lazy-youtube-video@1.3.0-beta.0</code></pre> <p>I will publish a stable <code>1.3.0</code> realese as soon as I am sure everything works properly.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/andrewvasilchuk"><img src="https://avatars.githubusercontent.com/u/44983823?v=4" />andrewvasilchuk</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>@delta0800, Actually there is no need for it. New version <code>1.3.0-beta.1</code> with SSR support is released.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/delta0800"><img src="https://avatars.githubusercontent.com/u/53184778?v=4" />delta0800</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Hello Andrew, </p> <p>Thanks for the email. Noted that. Have the issue resolve at your end? I will try tonight version 1.3.0 . The error message at safari actually is about the Allow attributes in iframe in my understanding. For the new release have you resolved it at your end? </p> <p>Thanks Lawrence </p> <p>Sent from my iPhone</p> <blockquote> <p>On 9 Dec 2019, at 19:11, Andrew <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> @delta0800, Actually there is no need for it. New version 1.3.0-beta.1 with SSR support is released.</p> <p>— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/delta0800"><img src="https://avatars.githubusercontent.com/u/53184778?v=4" />delta0800</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Hello Andrew, </p> <p>How are you today? I have updated the package to the latest release. I still got the message without correct 'allow' attribute. Maybe i have made some mistake. Below are screenshot of my template. </p> <p>View blade</p> <blockquote> <p>On Dec 9, 2019, at 6:11 PM, Andrew <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p>@delta0800 <a href="https://github.com/delta0800">https://github.com/delta0800</a>, Actually there is no need for it. New version 1.3.0-beta.1 with SSR support is released.</p> <p>— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <a href="https://github.com/andrewvasilchuk/vue-lazy-youtube-video/issues/6?email_source=notifications&email_token=AMVYSCUWWIZJIA2WXY25NM3QXYRUTA5CNFSM4JW4EUU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGIY5FQ#issuecomment-563187350">https://github.com/andrewvasilchuk/vue-lazy-youtube-video/issues/6?email_source=notifications&email_token=AMVYSCUWWIZJIA2WXY25NM3QXYRUTA5CNFSM4JW4EUU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGIY5FQ#issuecomment-563187350</a>, or unsubscribe <a href="https://github.com/notifications/unsubscribe-auth/AMVYSCRNU7CHLPEWPLARDGLQXYRUTANCNFSM4JW4EUUQ">https://github.com/notifications/unsubscribe-auth/AMVYSCRNU7CHLPEWPLARDGLQXYRUTANCNFSM4JW4EUUQ</a>.</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/andrewvasilchuk"><img src="https://avatars.githubusercontent.com/u/44983823?v=4" />andrewvasilchuk</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>@delta0800, Sorry but still I do not know hove to solve this issue? Are you running your code on site with <code>HTTPS</code> protocol?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/delta0800"><img src="https://avatars.githubusercontent.com/u/53184778?v=4" />delta0800</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Hello Andrew,</p> <p>How are you? Today is Sat hope you have a great weekends. </p> <p>Sorry for the late reply this few days. I done some research also from others they have this problem also On Safari. </p> <p>I tried also to run it through https have the same problem too. Just to make sure with you there’s no issue with the code I write right? I will keep on trying if I have find the answer I will email you too. </p> <p>Wish you have a nice day. </p> <p>Thanks Lawrence </p> <p>Sent from my iPhone</p> <blockquote> <p>On 11 Dec 2019, at 02:11, Andrew <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> @delta0800, Sorry but still I do not know hove to solve this issue? Are you running your code on site with HTTPS protocol?</p> <p>— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/andrewvasilchuk"><img src="https://avatars.githubusercontent.com/u/44983823?v=4" />andrewvasilchuk</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>@delta0800, Thanks a lot!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/delta0800"><img src="https://avatars.githubusercontent.com/u/53184778?v=4" />delta0800</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Happy New Year to you @Andrew. Welcome 2020! Cheers ! </p> <p>Sent from my iPhone</p> <blockquote> <p>On 2 Jan 2020, at 23:01, Andrew <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> @delta0800, Thanks a lot!</p> <p>— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/andrewvasilchuk"><img src="https://avatars.githubusercontent.com/u/44983823?v=4" />andrewvasilchuk</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>@delta0800, Do not getting this issue anymore.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/delta0800"><img src="https://avatars.githubusercontent.com/u/53184778?v=4" />delta0800</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Hello Sir, </p> <p>How are you? Hope you are fine. I am glad to hear that it’s fixed. I will check it. </p> <p>Thanks Lawrence </p> <p>Sent from my iPhone</p> <blockquote> <p>On 7 Mar 2020, at 19:03, Andrew <a href="mailto:notifications@github.com">notifications@github.com</a> wrote:</p> <p> @delta0800, Do not getting this issue anymore.</p> <p>— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.</p> </blockquote> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

andrewvasilchuk / vue-lazy-youtube-video

Getting this error in Safari, but other browsers work fine. #6