search

andrewvy / chrome-remote-interface

Elixir Client for the Chrome Debugger Protocol
https://hexdocs.pm/chrome_remote_interface
66 stars 31 forks source link

Fix for session missing init callback, does not need to be GenServer #26

Closed holsee closed 5 years ago

holsee commented 5 years ago

It would appear that the ChromeRemoteInterface.Session does not need to be a GenServer.

This will also remove the following warning:

warning: function init/1 required by behaviour GenServer is not implemented (in module ChromeRemoteInterface.Session).

We will inject a default implementation for now:

    def init(init_arg) do
      {:ok, init_arg}
    end
andrewvy commented 5 years ago

Whoops, probably a left-over from initial thinking. Thank you!