search

andreww / fox

A Fortran XML library
https://andreww.github.io/fox/
Other
59 stars 50 forks source link

wkml: kmlCreatePointStyle heading argument limits are wrong #1

Closed andreww closed 14 years ago

andreww commented 15 years ago

The heading argument to kmlCreatePointStyle accepts integer values between -180 and 180 degrees. This is checked in the code and an error is raised for values outside this range. There are tests to check this works. However, google's kml spec page says the value should be between 0 and 360. We should either only accept numbers in that range, or add 360 to negative values to produce the correct output without breaking the API.

andreww commented 15 years ago

Also, why is the heading an integer? Should check the xsd for kml.

andreww commented 14 years ago

The schema actually says:

So it should be real, and between -360 and 360. I'll follow the Google docs which say 0 to 360.

andreww commented 14 years ago

Fixed by: http://github.com/andreww/fox/commit/5f1f66a79511b5cb15fda208964076e246cc0055 Allowed values go from -360 to 360.