search

andrewwiik / Maize

Porting the iOS 11 Control Center to iOS 10
51 stars 16 forks source link

Music Module isn't RTL aligned #100

Open Aransh opened 6 years ago

Aransh commented 6 years ago

http://imgur.com/QE0Y73c Artwork and airplay icons should be flipped, also, the volume indicators should be mirrored (same thing for the volume module BTW... it should also be flipped) Also, either the scrubber goes from left to right (like Apple does nativly, although I don't like it), or the next/previous buttons switch places, in the photo I attached, tapping the right button skips to the next song, while the scrubber makes it look like it should scrub to the beginning of the song. Lastly, the time stamps look a bit... off

andrewwiik commented 6 years ago

Could you give me a screenshot what is looks like on RTL iOS 11?

Aransh commented 6 years ago

@andrewwiik Image My friend sent me this, hope this helps

andrewwiik commented 6 years ago

Perfect

andrewwiik commented 6 years ago

Do you know which way the marquee scrolls when the text is too long in RTL mode?

Aransh commented 6 years ago

@andrewwiik in the music app it goes from right to left

andrewwiik commented 6 years ago

Does it in Maize currently?

Aransh commented 6 years ago

@andrewwiik yup

Aransh commented 6 years ago

@andrewwiik I just updated to 1.0.3 and saw you started fixing this issue, thanks :) but I just wanted to say, on songs with Hebrew names, the Marquee goes to the correct direction (from right to left), but it starts scrolling from the wrong end... Image this screenshot is of how the text looks at before it started scrolling, while the cut-off text on the right is the band's name (which should come first), hope you can fix this too

andrewwiik commented 6 years ago

Honestly not sure how to fix the scrolling bug as when I try to visualize it in my head I can't handle it, could you maybe get me videos of it scrolling on an iOS 11 device and Maize so I can compare and adjust?

Aransh commented 6 years ago

@andrewwiik well, basically the bug is only about the point from which the scrolling begins, so I can even make the recording using Maize and a little editing.

This is how Maize does it now: https://vimeo.com/244950545

This is how it should start: https://vimeo.com/244950565

This is the song's full name for reference: Image (This specific song in the album features 3 artists so it has a long artist list)

For reference, this is how it works in the music app: https://vimeo.com/244950596

P.S. The problem is only for songs with Hebrew (or any other RTL language) in their names, with English songs it works correctly