andrewyng / translation-agent

MIT License
4.88k stars 564 forks source link

Add webui App #30

Closed snekkenull closed 4 months ago

snekkenull commented 5 months ago

Context

What is the purpose of this PR? Is it to

Please link to any issues this PR addresses. https://github.com/andrewyng/translation-agent/issues/23

Changelog

Add a gradio WebUI for translation-agent, run it locally or cloud.

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

j-dominguez9 commented 4 months ago

Making change suggestions as I go:

snekkenull commented 4 months ago

@j-dominguez9 Thank you for your suggestion, it has been modified as you suggested.

Preview: image

j-dominguez9 commented 4 months ago

@snekkenull Thank you for your work on this and incorporating the changes. I went ahead and made minor formatting fixes to conform with python style. The only thing it's missing before merging and hoping you could help with this last detail is an error that comes out when you press the Clear button. Attached output below. Thanks! Screenshot from 2024-07-08 10-38-17

snekkenull commented 4 months ago

@j-dominguez9 Thank you for testing, I have benefited greatly from your code style and work. I have fixed the issue (the problem was with a error on the ClearButton component's event logic).

j-dominguez9 commented 4 months ago

@snekkenull of course! Thank you for your contribution. Note for self future reference: There is still an error if the user doesn't have an OPENAI_API_KEY in the .env file, even if they don't intend to use OpenAI. This however traces back to the utils file, which will be addressed soon, so I'll come back to this part afterwards to make sure it works without having an OpenAI key.

methanet commented 4 months ago

@snekkenull many thanks for working on the app! One small issue I just noticed are several inconsistencies between the READMEs. Would you be able to take a stab at those?

snekkenull commented 4 months ago

Thank you very much for your suggestions and feedback. It is true that some of the documentation is an expression of past versions that were not revised in a timely manner. The current version uses OpenAI-compatible format APIs with less dependencies and pervasiveness, but is not easily extensible. In response to your feedback, I will make a submission in the next update. Thanks again for the reminder. 🙇

Nedelina Teneva @.***> 于2024年7月12日周五 08:18写道:

@snekkenull https://github.com/snekkenull many thanks for working on the app! One small issue I just noticed are several inconsistencies between the READMEs. Would you be able to take a stab at those?

  • Can you double check for consistency with the main README and edit as needed? For example, the app README says "This repository contains..." and has its own contributing guide - those can be removed/adjusted as this is now part of this repo.
  • Explicitly list all the APIs supported.
  • Also briefly describe the advanced options the UI supports.
  • I think the Linux and Window installation can be added to the main README. You can briefly describe what the '--with app' option is and link to the app directory.

— Reply to this email directly, view it on GitHub https://github.com/andrewyng/translation-agent/pull/30#issuecomment-2224169407, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5UFKQWJ4LVCTXT5JDG7SALZL4OG5AVCNFSM6AAAAABKDJFJG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRUGE3DSNBQG4 . You are receiving this because you were mentioned.Message ID: @.***>