Fix mixed-direction text layout in translations (Resolves #34) - Githubissues

andrewyng / translation-agent

MIT License

4.83k stars 553 forks source link

Fix mixed-direction text layout in translations (Resolves #34) #37

Open Salah-Sal opened 4 months ago

Salah-Sal commented 4 months ago

Context

What is the purpose of this PR? Is it to

[x] add a new feature
[ ] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses. Fixes #34

Changelog

Removed a redundant line in utils.py where source_text was being replaced unnecessarily.
Added the tokenize_mixed_direction_text function in process.py to handle mixed-direction text (LTR within RTL).
Updated the translator and translator_sec functions in process.py to use tokenize_mixed_direction_text for processing the translations.

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

[x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[x] update docstrings for any new or updated methods or classes
[ ] run unit tests via pytest tests
[ ] include relevant commands and any other artifacts in this summary (eval results, etc.)