andrey-git / home-assistant-custom-ui

Custom UI elements for https://home-assistant.io
https://home-assistant.io
MIT License
528 stars 97 forks source link

Theme change not working on Firefox and Edge #133

Closed bieniu closed 6 years ago

bieniu commented 6 years ago

I use Custom UI (local install with Customizer component) to change theme of sensors icons. It works perfectly on Chrome/Opera but on Firefox and Edge it’s completely ignored.

Checklist

Browser + Version: Firefox 60.0.1

CustomUI version: 20180521

Home Assistant release (hass --version): 0.69.1

Problem-relevant configuration.yaml entries:

homeassistant:
  customize_glob:
    'binary_sensor.*_status':
      device_class: connectivity
      custom_ui_state_card: state-card-custom-ui
      theme: 'grey'

frontend:
  javascript_version: auto
  themes:
    grey:
      paper-item-icon-color: '#969696'
      paper-item-icon-active-color: '#44739e'

customizer:
  custom_ui: local

Any errors from browser Javascript console: no errors

andrey-git commented 6 years ago

Does "regular" (i.e not per-entity) theming work for you in FF? i.e. if you select this "grey" theme - do all icons become grey?

I tried in FF52 on Linux with HA 0.70 and everything works fine.

bieniu commented 6 years ago

Yes, when I change theme in frontend into 'gray' the icons of all entities with state 'off' change color to gray. I tried in FF60, FF52 and Edge and always the same issue.

andrey-git commented 6 years ago

Could you attach a screenshot from Chrome where it is working, so I better understand the setting?

bieniu commented 6 years ago

Chrome - icons of entities with state 'off' are grey, with state 'on' - blue chrome

Firefox - icons of entities with state 'off' are blue, with state 'on' - yellow firefox

andrey-git commented 6 years ago

Thanks, I reproduced the issue, trying to debug now...

andrey-git commented 6 years ago

Fixed in release 20170528