search

andrey-skl / ng-annotate-loader

Webpack loader to annotate angular applications
MIT License
120 stars 28 forks source link

Sourcemaps #11

Closed jvmccarthy closed 9 years ago

jvmccarthy commented 9 years ago

Attempts to fix #10 where there are issues with chained source maps by following the example of BabelJS. Also upgrades to the latest ng-annotate (which changes the souremap option to map).

andrey-skl commented 9 years ago

@jvmccarthy unluckily have unclear error when building my large project

/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/node_modules/source-map/lib/source-map/source-map-consumer.js:697
        throw new Error('"' + aSource + '" is not in the SourceMap.');
              ^
Error: "../../../../../../../../../../../../../../../../../../../../../../../../app/blocks/app/app.js" is not in the SourceMap.
    at SourceMapConsumer_sourceContentFor [as sourceContentFor] (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/node_modules/source-map/lib/source-map/source-map-consumer.js:697:15)
    at /Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/node_modules/source-map/lib/source-map/source-node.js:138:42
    at Array.forEach (native)
    at Function.SourceNode_fromStringWithSourceMap (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/node_modules/source-map/lib/source-map/source-node.js:137:34)
    at SourceMapSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/SourceMapSource.js:41:20)
    at ReplaceSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ReplaceSource.js:55:29)
    at CachedSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/CachedSource.js:41:22)
    at PrefixSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/PrefixSource.js:27:26)
    at /Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:38:49
    at Array.map (native)
    at ConcatSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:37:60)
    at /Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:38:49
    at Array.map (native)
    at ConcatSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:37:60)
    at /Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:38:49
    at Array.map (native)
    at ConcatSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:37:60)
    at /Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:38:49
    at Array.map (native)
    at ConcatSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:37:60)
    at /Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:38:49
    at Array.map (native)
    at ConcatSource.node (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/ConcatSource.js:37:60)
    at ConcatSource.proto.sourceAndMap (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/SourceAndMapMixin.js:22:18)
    at CachedSource.sourceAndMap (/Users/me/Documents/work/myproject/client/node_modules/webpack/node_modules/webpack-core/lib/CachedSource.js:34:28)
    at Tapable.<anonymous> (/Users/me/Documents/work/myproject/client/node_modules/webpack/lib/SourceMapDevToolPlugin.js:55:32)
    at Array.map (native)
    at Tapable.<anonymous> (/Users/me/Documents/work/myproject/client/node_modules/webpack/lib/SourceMapDevToolPlugin.js:43:84)
    at Array.forEach (native)
    at Tapable.<anonymous> (/Users/me/Documents/work/myproject/client/node_modules/webpack/lib/SourceMapDevToolPlugin.js:42:11)
andrey-skl commented 9 years ago

Have found solution: empty sourceRoot = '' should be added to merged map. Also, without annotateMap.sources[0] = filename; sokra's visualization doesnt't work for me.