andrey-zherikov / argparse

Parser for command-line arguments
https://andrey-zherikov.github.io/argparse/
Boost Software License 1.0
30 stars 6 forks source link

Update readme #121

Closed SirNickolas closed 9 months ago

SirNickolas commented 9 months ago

A follow-up of #109.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7bfd802) 97.76% compared to head (d0f88f5) 97.81%. Report is 3 commits behind head on 2.x.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #121 +/- ## ========================================== + Coverage 97.76% 97.81% +0.04% ========================================== Files 25 25 Lines 1479 1467 -12 ========================================== - Hits 1446 1435 -11 + Misses 33 32 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SirNickolas commented 9 months ago

Could you please return spaces back that were around dashes (that you replaced with Unicode characters)?

Turns out it’s a British/American difference. BrE style guides recommend using en dashes surrounded with spaces while AmE suggest unspaced em dashes. I guess the former looks more appealing to you, doesn’t it?

https://practicaltypography.com/hyphens-and-dashes.html https://english.stackexchange.com/questions/497006/in-britain-which-is-more-common-the-em-dash-or-the-en-dash

I’ll perhaps fix everything in one commit.

andrey-zherikov commented 9 months ago

I guess the former looks more appealing to you, doesn’t it?

Yes, IMO it's a bit more readable with spaces around.