search

andrey-zherikov / argparse

Parser for command-line arguments
https://andrey-zherikov.github.io/argparse/
Boost Software License 1.0
30 stars 6 forks source link

Fix compatibility with D 2.099 #146

Closed SirNickolas closed 8 months ago

SirNickolas commented 8 months ago

Closes #144.

I’m planning to reduce the minimal required version of the D frontend down to 2.095. Why this version? Because I tried 2.094, and the compiler failed to infer that (generated) opEquals of a struct containing a SumType was const. That seemed too suspicious to me; I’m afraid it can backfire in any unexpected way. I could have understood something wrong though; worth checking once again.

Should I continue working on lowering the requirements in this PR, or would you prefer to merge it in its current state?

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2454a72) 98.76% compared to head (be9c0e3) 98.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #146 +/- ## ======================================= Coverage 98.76% 98.76% ======================================= Files 26 26 Lines 1786 1786 ======================================= Hits 1764 1764 Misses 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrey-zherikov commented 8 months ago

Should I continue working on lowering the requirements in this PR, or would you prefer to merge it in its current state?

Let's do in separate PR