search

andrey-zherikov / argparse

Parser for command-line arguments
https://andrey-zherikov.github.io/argparse/
Boost Software License 1.0
30 stars 6 forks source link

Convert Config.errorHandler from delegate to function #153

Closed andrey-zherikov closed 8 months ago

andrey-zherikov commented 8 months ago

Closes #118

I think having errorHandler as delegate was over-engineering that didn't even work correctly.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7e08d53) 98.78% compared to head (fbf5663) 98.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #153 +/- ## ========================================== - Coverage 98.78% 98.72% -0.07% ========================================== Files 27 27 Lines 1810 1803 -7 ========================================== - Hits 1788 1780 -8 - Misses 22 23 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ljmf00-wekaio commented 8 months ago

@andrey-zherikov It's weird that I'm getting core.exception.OutOfMemoryError@core/lifetime.d(126): Memory allocation failed after this change, on one of my unittests. I can't understand the issue, but perhaps, do you have any insight? Maybe its on my side, but my CI doesn't pass only when changing this dependency, isolated.

andrey-zherikov commented 8 months ago

@ljmf00-wekaio Do you have test case that I can use to reproduce the issue?

ljmf00-wekaio commented 8 months ago

@ljmf00-wekaio Do you have test case that I can use to reproduce the issue?

No unfortunately. I'll keep you updated here, or perhaps I can create an issue (I don't know if its relevant if its on my side). Maybe I can clean CI cache, it might include bogus ldc codegen cache or objects.

andrey-zherikov commented 8 months ago

Please create separate issue then.

ljmf00-wekaio commented 8 months ago

xref https://github.com/andrey-zherikov/argparse/issues/157