search

andreykaipov / goobs

Go client library for OBS Studio
Apache License 2.0
137 stars 23 forks source link

exposing UUIDs #151

Closed progrium closed 6 months ago

progrium commented 6 months ago

is there a reason why UUIDs (for example, of scenes) aren't exposed? they're in the JSON data.

andreykaipov commented 6 months ago

Hey @progrium - are you using an up-to-date version of this library? UUIDs were added in obs-websocket v5.4.0, and the corresponding tag for that in goobs is v1.2.0: https://github.com/andreykaipov/goobs/releases/tag/v1.2.0

progrium commented 6 months ago

For which resources? I don't see it for scenes: https://pkg.go.dev/github.com/andreykaipov/goobs@v1.2.3/api/typedefs#Scene

andreykaipov commented 6 months ago

Ah I see what you mean now... The structs in that package are manually maintained outside of protocol version updates, so I never actually updated them when the automation ran against the v5.4.0 protocol. 😅 So only requests that had UUID fields declared directly in the protocol were added like this one: https://pkg.go.dev/github.com/andreykaipov/goobs@v1.2.3/api/requests/scenes#GetSceneListResponse.

I added the missing fields in https://github.com/andreykaipov/goobs/pull/152, along with some checks that should hopefully prevent things like this happening in the future. Should be fixed in v1.3.0. Thank you for pointing it out! Please lemme know if you run into anything else.

progrium commented 6 months ago

Ah, UUIDs everywhere! Great, thank you for that and this library!