search

andreykaipov / goobs

Go client library for OBS Studio
Apache License 2.0
137 stars 22 forks source link

Very small typo fix. But hopefully helpful #42

Closed coltonhughes closed 2 years ago

coltonhughes commented 2 years ago

This did throw me for a loop when I utilized a switch statement. Small nonetheless.

afriza commented 2 years ago

This variable is, as the filename says, autogenerated.. The typo is in obs-websocket project..

https://github.com/obsproject/obs-websocket/blob/a25427c7cc4b4f0f6ac96ebe2723fc3db8906f22/docs/generated/protocol.json#L2777

coltonhughes commented 2 years ago

Interesting. Disregard the PR then.

afriza commented 2 years ago

It will be auto-fixed when the library is regenerated from obs-websocket v5.1.0+ since it is fixed in v5.1.0

https://github.com/obsproject/obs-websocket/commit/bc18401fb060f0278e8a2aaad9fa318f5e6b91d8

And is not released yet in OBS Studio

https://github.com/obsproject/obs-studio/commit/53ffaf56c193e5e9b01322a137673aebd0dce9e5

Watch out for compile error when upgrading later..

afriza commented 1 year ago

It will be released in OBS Studio v29 and goobs has been regenerated with the fix (PR #43).