search

andreykurenkov / HybridVec

Repo for CS 224N project
4 stars 3 forks source link

Final Code cleanup #18

Closed haroldmei closed 5 years ago

haroldmei commented 5 years ago

1, models are all in the same package now, including Def2VecModel and BaselineModel; 2, Created a utils package, more work to be done. 3, Remove unnecessary package imports

@andreykurenkov please advice if anything, thanks!

andreykurenkov commented 5 years ago

@haroldmei the code changes look good to me. I pushed further reorganization of files. Could you make train.py and other files work with this reorganization? Then should be good to merge.

haroldmei commented 5 years ago

@andreykurenkov 1, Package can be installed with 'python setup.py install' and uninstalled with 'pip uninstall hybridvec' 2, train.py is running 3, the 'install_requires' in setup.py is left empty just for now. (mainly because versions of packages I installed is newer than that of them in the package list, so it needs to be updated later.) Please reveiw, thanks!

andreykurenkov commented 5 years ago

@haroldmei pls install pytorch-monitor from libs so as to avoid commit messages like "auto commit tracked files for new experiment: def2vec on "