Open sidkshatriya opened 2 years ago
hm, so instead of passing additional arguments to fzf-file
this PR makes a separate command for that purpose? I think your previous method is more simple in a sense that it's just additional arguments, taht allow you to define your own versions of fzf-file
and binding them to convenient keys, like "only search hidden files" or "only search current buffer's extension files". This one seems less flexible in this regard.
Here is my reasoning why this is a better approach:
--abc
. But now you need --xyz
. Also it may be that --abc
and --xyz
may be mutually exclusive -- you won't be able to specify --xyz
if --abc
is already there. However this simpler approach will allow that.In general this approach allows an arbitrary alternative command and it's simpler for the end user...
Maybe we could have both ways, as they aren't mutually exclusive?
fzf_file_alternative_command
.Here is the sample kakrc configuration now using the simplified approach.
P.S. As this commit reverts some changes of the previous commit cb07538a88dd51b1c03800d6c451d2d71e7b80a5 , it is also useful to see the following.
https://github.com/andreyorst/fzf.kak/compare/95b12b1fe93c6db0441c61062823231a28eed037..a1012402af3db8411144877437697fb678424a24
The above link compares this PR with the commit
The above diff is probably simpler to review.