search

andreyorst / plug.kak

Plugin manager for Kakoune
MIT License
197 stars 18 forks source link

feat(plug.kak): update define-command shell options #17

Closed vinnyA3 closed 6 years ago

vinnyA3 commented 6 years ago

The new Kakoune update (v2018.10.27) seems to have made changes to the define-command option set, thus breaking the plugin manager. Made the appropriate updates to plug.kak.

[EDIT] I just realized there is a dev branch. Should I have issued a pull request there instead?

[EDIT2] I see that changes have been made on the dev branch

andreyorst commented 6 years ago

Master branch should be compatible with latest release, however v2018.10.27 isn't in the repos of most distributions yet, so I don't actually know how to deal with these breaking changes. Kakoune-dev branch (will be renamed to kakoune-git which I think is more convenient) is in sync with Kakoune master branch, and should be used only if you use git package which is updated rapidly.

I'm thinking that I should keep two latest releases as separate branches and backport new features to them from kakoune-git branch. I could handle different Kakoune versions via some sort of try catch blocks but it will make lot's of duplicates in the code unfortunately.

vinnyA3 commented 6 years ago

I'm currently using the dev branch; all is working well :). Void linux just updated the Kakoune package (I'm surprised .. I thought Arch would update first).

I agree, supporting the two latest releases would be best. Things could get quite messy when there are too many versions to support.