andreyorst / plug.kak

Plugin manager for Kakoune
MIT License
197 stars 18 forks source link

Kakoune becomes unresponsive when requested git repo is wrong, could we get an error message instead? #50

Closed scarab5q closed 5 years ago

scarab5q commented 5 years ago

Had this issue for weeks until I just fixed it. Over this time I thought this thought it was many things before I realised that I had pasted the repo name into the "plug" command wrong. To recreate put the following line into your kakrc:

plug "alexherbo2/auto-pairs" (it should be auto-pairs.kak, yes this is the exact thing I have left in my kakrc for weeks it is really dumb for me to not have noticed this)

This also works with any git repo that doesnt exist, I've tested it. Would it at all possible for the fifo buffer to display an error instead? Because of a mistake which is reletively easy to make this issue has plagued me for ages and I couldnt work out why. Just thought I'd point out this bug. Otherwise I love this, keep up the good work !

andreyorst commented 5 years ago

Yeah, that's quite similar to another issue appeared not so long time before: #47 Unfortunately I can't do much with private repos, and that's the case of such issue, if you try to clone this repo in the shell, it would ask for Username and Password:

$ git clone https://github.com/alexherbo2/auto-pairs
Cloning into 'auto-pairs'...
Username for 'https://github.com': vaiv
Password for 'https://vaiv@github.com': 
remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/alexherbo2/auto-pairs/'

And you can't insert Username, and Password from Kakoune. The problem is, that this is default behavior for unexisting repos.

andreyorst commented 5 years ago

I'm closing this in favor of #47 as it pretty the same issue. Let's continue the discussion there.