search

andreyorst / plug.kak

Plugin manager for Kakoune
MIT License
197 stars 18 forks source link

Theme post-update hook fails on macOS #66

Closed evanrelf closed 5 years ago

evanrelf commented 5 years ago

The find command here is what's failing:

https://github.com/andreyorst/plug.kak/blob/7a41cdff777f6d46b70f53833d37d3e6343efaa9/rc/plug.kak#L133

Changing find -type f ... to find . -type f ... seems to fix this on macOS.

andreyorst commented 5 years ago

bsd find... While I understand that this dot makes sense, but still, seriously why didn't they made it optional?

evanrelf commented 5 years ago

I think the optional path is a GNU find feature. Looks like POSIX find requires a path.

https://www.unix.com/man-page/posix/1p/find/

While I like how Kakoune defers to the shell for scripting, it's annoying having to worry about the idiosyncrasies of each OS you expect to run on...

andreyorst commented 5 years ago

While I like how Kakoune defers to the shell for scripting, it's annoying having to worry about the idiosyncrasies of each OS you expect to run on...

Well, that's how software works. Even apps on JVM not truly cross platform sometimes.

I think the optional path is a GNU find feature. Looks like POSIX find requires a path.

Yeah, I know. And other find usages in plug.kak are using path and respect the POSIX format. Theme post hooks were added long after that, and I simply forgot about it, so that's my bad.