search

andreyorst / powerline.kak

Kakoune modeline, but with passion
MIT License
50 stars 8 forks source link

Improved English mechanics: fixed grammar and punctuation; improved diction. #26

Closed bound-variable closed 2 years ago

bound-variable commented 2 years ago

Breaking change: yes/no

Description: I've edited the introduction to the README. While doing so, I made the introduction a single line composed of multiple sentences. The original introduction is broken up across multiple lines. I'm not sure what the reason for this is. If it's necessary, I can change it back to cross multiple lines.

If the changes are accepted, I can edit the entire README for you.

andreyorst commented 2 years ago

Thanks! But please keep one sentence per line, as it makes reviewing diffs a much simpler task.

https://rhodesmill.org/brandon/2012/one-sentence-per-line

bound-variable commented 2 years ago

Okay! I didn't know that. I'll read that article.

Sent with ProtonMail secure email.

------- Original Message ------- On Monday, April 4th, 2022 at 2:37 PM, Andrey Listopadov @.***> wrote:

Thanks! But please keep one sentence per line, as it makes reviewing diffs a much simpler task.

https://rhodesmill.org/brandon/2012/one-sentence-per-line

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

bound-variable commented 2 years ago

I'm new to working with git like this. Let me know if everything is okay.

andreyorst commented 2 years ago

Looks great to me, but It seems that there are some conflicts for some reason. I don't think I've pushed anything, though.

bound-variable commented 2 years ago

Looks great to me, but It seems that there are some conflicts for some reason. I don't think I've pushed anything, though.

On my end, GitHub is saying there are no conflicts. Is there anything I can do?

andreyorst commented 2 years ago

I wasn't able to rebase for some reason, so I've just merged it. Thanks! I'll give it a few tweaks here and there, as Ive spotted some mistakes of my own.