andreypopov / node-red-contrib-miio-roborock

Xioami Roborock node-red nodes
Apache License 2.0
30 stars 11 forks source link

Token is stored in flows.json, not encrypted in flow_creds.json #54

Open NickBorgers opened 1 year ago

NickBorgers commented 1 year ago

Describe issue This node stores the token in a way that causes it to be written to flows.json instead of flows_creds.json. This is definitely exposing peoples' credentials, like mine right here because I'm using the Projects feature to back up my flows to GitHub.

Your flow here <removed link to line with password b/c the commit contains a credential that is hard to rotate>

I found this documentation in the Node Red project which seems to be describing how to store configuration in the credential type, but I'm unfamiliar with writing my own nodes.

X-Link to this issue I raised for the same problem on a different node's project X-Link 2