search

andreypopov / node-red-contrib-miio-roborock

Xioami Roborock node-red nodes
Apache License 2.0
32 stars 12 forks source link

Move token to credentials object #55

Open NickBorgers opened 1 year ago

NickBorgers commented 1 year ago

Resolves #54

BTW some of your (test, at least) tokens are exposed in this repository: https://github.com/andreypopov/node-red-contrib-miio-roborock/search?q=token

NickBorgers commented 1 year ago

This change is NOT working, and I don't understand why.

The code structure is definitely different than this module, and doesn't quite seem to match the docs for the credentials feature, in that there isn't a distinct "node definition".

NickBorgers commented 1 year ago

Wow this was frustrating: https://github.com/andreypopov/node-red-contrib-miio-roborock/pull/55/commits/3de23807c814f6fcf3964a0556279e31e8ee98f3

Anyway, working now