search

andreypopp / autobind-decorator

Decorator to automatically bind methods to class instances
MIT License
1.45k stars 66 forks source link

Maintainers needed #35

Closed andreypopp closed 6 years ago

andreypopp commented 8 years ago

As I no longer use this library it needs new maintainers.

stevemao commented 8 years ago

Hi @andreypopp I'm really keen to maintain this. My company Atlassian is using this so I have good support.

stevemao commented 8 years ago

cc @bradleyayers

andreypopp commented 8 years ago

Nice, let's wait some time (a day) so others can respond too. Also cc @domarmstrong as he already has commit access to the repo.

bradleyayers commented 8 years ago

@andreypopp I'm interested why you no longer use this. Do you have a different pattern that you use now?

andreypopp commented 8 years ago

@bradleyayers completely switched to use class instance properties:

onClick = (e) => {
  ...
};
stevemao commented 8 years ago

typescript doesn't seem to support this yet.

andreypopp commented 8 years ago

@stevemao what's you npm username so I could add you there?

domarmstrong commented 8 years ago

Sounds good @stevemao! Sadly I don't use either for quite a while now as I moved in other directions now.

stevemao commented 8 years ago

Hi @andreypopp can you add @bradleyayers as well? Also would you mind adding me to npm? Thanks guys.

stevemao commented 8 years ago

@stevemao what's you npm username so I could add you there?

Sorry, It's stevemao

andreypopp commented 8 years ago

Hi @andreypopp can you add @bradleyayers as well? Also would you mind adding me to npm?

Done

mockdeep commented 7 years ago

@andreypopp out of curiosity, how are you handling binding now?

bradleyayers commented 7 years ago

I just use the standard ES7 property assignment:

foo = () => { ... }
baba43 commented 7 years ago

@bradleyayers I found this to cause problems while hot reloading since methods created this way will not be hot loaded (correctly).

nurbek-ab commented 6 years ago

@baba43 Also class property methods cause problems with testing. For example you cannot use jest.spyOn on a class property method because it's not in the prototype.

stevemao commented 6 years ago

@nurbek-ab there's already tickets. Please search the issue tracker and find the solutions