search

andreypopp / react-css-components

Define React presentational components with CSS
677 stars 14 forks source link

extraClassName #19

Open aymericbouzy opened 7 years ago

aymericbouzy commented 7 years ago

Before I write tests for it, is this the way you envisioned it?

andreypopp commented 7 years ago

Looks good, but the tests are failing. I think at this point we might need to migrate to Jest test runner and use its snapshot testing functionality so updating snapshots can be done automatically.

aymericbouzy commented 7 years ago

Migrating to Jest test runner is a different PR IMO. Would you like to do it now? Or I can update the tests to make them pass.

andreypopp commented 7 years ago

You can just update the tests. On Thu, 16 Mar 2017 at 15:07 Aymeric Bouzy notifications@github.com wrote:

Migrating to Jest test runner is a different PR IMO. Would you like to do it now? Or I can update the tests to make them pass.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/andreypopp/react-css-components/pull/19#issuecomment-287037873, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB3glSoXrElPAxRxwlzf7KBgVn4iAnfks5rmSYZgaJpZM4MfG_x .