search

andreypopp / reactify

[DEPRECATED] Browserify transform for JSX (superset of JavaScript used in React library by Facebook)
MIT License
690 stars 68 forks source link

Make source map generation optional #48

Closed aldendaniels closed 8 years ago

aldendaniels commented 9 years ago

This is nice when debugging JSX code

aldendaniels commented 9 years ago

@andreypopp - I've made the change you suggested.

hbrls commented 9 years ago

@aldendaniels You've mentioned debugging. Did you encounter the same as I have? The grey lines in Chrome and break points does not work

hbrls commented 9 years ago

And if I change the true to false in the node_modules/reactify/index.js, the whole thing works as before and looks good to me.

aldendaniels commented 9 years ago

@hbrls - I hadn't noticed the gray bar issue with Reactify.

I recently switch to babelify - which also transpiles JSX -> JS.

Unlike Reactify, babelify uses acorn-jsx under the hood instead of FBs offical (esprima-based) JSX transpiler.

Anyway, today I noticed that Babel has the same issue with gray bars that you described:

screen shot 2015-04-21 at 2 03 03 pm

Glad to know that disabling source maps fixes the issue.

aldendaniels commented 9 years ago

@hbrls - saw your comment in http://stackoverflow.com/questions/29650951/what-are-these-grey-lines-in-the-chrome-sources-panel

So you also noticed that the gray line issues occurs both on babelify and reactify.