search

andreypopp / reactify

[DEPRECATED] Browserify transform for JSX (superset of JavaScript used in React library by Facebook)
MIT License
690 stars 68 forks source link

Adding 'exclude' option #69

Closed fantactuka closed 8 years ago

fantactuka commented 9 years ago

Something that might be useful for #30, since it allows explicitly exclude files or folders from being transformed. Just a draft for discussion.

browserify().transform(['reactify', {
  es6: true,
  target: 'es5',
  exclude: [
    '**/lib/**/*.js'
  ]
}])
andreypopp commented 9 years ago

I like that.

Can you make it precompute Minimatch object from options and then reuse it?

fantactuka commented 9 years ago

Makes sense. It also uses relative file name for matchers now

andreypopp commented 9 years ago

Looks good. Could you add tests and update README?

SimonFrr commented 9 years ago

Hey @andreypopp, will you merge this if I write the tests and update the README myself? I'd really like to have this (and given that I wasn't the only one, I wonder why everybody just stopped talking about it?)

andreypopp commented 9 years ago

@SimonFrr everybody moved to babelify as reactify is going to be deprecated soon. If you want to continue using reactify I'll merge your PR.

SimonFrr commented 9 years ago

@andreypopp ha ha alright, I guess I'll have to move on then. Thanks anyway!