search

andreypopp / validated

Validate your configurations with precise error messages
91 stars 14 forks source link

Babel config in package.json causing test failure #26

Closed sstur closed 6 years ago

sstur commented 6 years ago

Hi. Thanks for this awesome project!

In one case where we use this in a RN project, our CI tests (using Jest) are failing with an error about cannot find babel preset prometheusresearch.

I believe the reason is that in your package.json you have some babel config which gets checked into npm:

  "babel": {
    "presets": [
      "prometheusresearch"
    ]
  },

For some reason this confuses Jest/babel and it tries to convert your published code using babel.

Would you be open to a PR that moves this config to a .babelrc file in your project's root that does NOT get published to npm?

Thanks much!

/cc @darcien who has been helping diagnose this.

andreypopp commented 6 years ago

Yep, sure, let's fix it.