search

andreypopp / validated

Validate your configurations with precise error messages
91 stars 14 forks source link

upgrade to flow-bin 0.95.1 and fix indent-string libdef #35

Open LoganBarnett opened 5 years ago

LoganBarnett commented 5 years ago

This upgrades to flow-bin 0.95.1, which includes an update to JSON.stringify. This update means stringify can return string | undefined (undefined is covered by a few edge cases). Flow does not accept undefined in string interpolations, so the string "undefined" has been used in these cases as a fix.

indent-string changed its signature in 3.2.0. The updated libdef has been submitted to flow-typed (see https://github.com/flow-typed/flow-typed/pull/3219) but until it is accepted the libdef has been copied here manually. Uses of the indent call have been fixed. It is suspected that the upgrade of Flow has increased type coverage here and flagged this as an error, because this should have otherwise gone undetected.

LoganBarnett commented 5 years ago

The updated libdef was merged into flow-typed and I've updated the PR to use the official version instead of the manual copy.

LoganBarnett commented 1 year ago

@andreypopp @Alxandr hey folks - is there anything I can do to help merge this PR? I've recently had to touch on some older work which is depending on a fork of this so it can use a more modern version of Flow.

Thanks!

Alxandr commented 1 year ago

Unfortunately I basically have no memory of this (nor use flow anymore) - so I'm probably not the right person to make any calls here.