conf/feedserver/adapter/sample.properties has an unncessary property configFile. It shouldn't

[GoogleCodeExporter]

adapter properties file should only have properties the adapter absolutely
needs. sample adapter has an unnecessary property "configFile".

removing it breaks the tests. FeedConfiguration constructor requires this
property to exist, otherwise it fails.

Original issue reported on code.google.com by vasun...@gmail.com on 16 Feb 2008 at 12:07

[GoogleCodeExporter]

abdera 0.4.0 has the same problem.
James @ abdera may have just copied it over from our code.
in abdera, /server/src/test/resources/abdera/adapter/sample.properties has 
  configFile=dummyFileLocation
makes no sense to me.

I think an adapter should know what properties it should expect and get those
properties from FeedConfiguration when necessatry.
FeedConfiguration shouldn't care about anything other than just the ones 
required by
ALL adapters.

We need to produce a patch for Abdera. 
also, preferably, some unittests too.

Original comment by vasun...@gmail.com on 16 Feb 2008 at 12:18

[GoogleCodeExporter]

I think sample adapter is a one of case. Any feed will have an adapter which 
will
connect to an data source. And hence it will have a adapter config and thus and
adapter config location.
So only reason for putting adapter config location in the constructor was that 
All
the real life adapters will need this field.
Thoughts ?

Original comment by abhin...@gmail.com on 18 Feb 2008 at 8:09

[GoogleCodeExporter]

This code is going to go away pretty soon - once feedserver code is refactored 
based
on Abdera. so, fixing anything here is not that useful for the long term.

we can continue this discussion on abdera mailing list. 

Original comment by vasun...@gmail.com on 19 Feb 2008 at 10:19

• Changed state: WontFix