search

andreyv / sbupdate

Generate and sign kernel images for UEFI Secure Boot on Arch Linux
GNU General Public License v3.0
225 stars 20 forks source link

Remove unnecessary wait #20

Closed brandsimon closed 4 years ago

andreyv commented 4 years ago

The wait is necessary to check the exit status of the <(cat "${INITRD_PREPEND[@]}" "${initrd}") process substitution. Otherwise it could fail and the script would continue nonetheless.

See c0a7e52aa5ce4dcb1c2de2cf59e66728654a940d.

brandsimon commented 4 years ago

I checked the manpage, and wait waits for process completion, there is no exit status check. What am I missing?

andreyv commented 4 years ago

See the last sentence in the description of wait in the bash(1) man page:

Otherwise, the return status is the exit status of the last process or job waited for.

brandsimon commented 4 years ago

Ah, now I see, I did not know the set -e was set. Thank you.