andreyv / sbupdate

Generate and sign kernel images for UEFI Secure Boot on Arch Linux
GNU General Public License v3.0
225 stars 20 forks source link

Bashism in Makefile #22

Closed gdzx closed 4 years ago

gdzx commented 4 years ago

The install target in the Makefile contains the following chunk:

$(INSTALL) -D -m 0644 -t "$(DESTDIR)/usr/share/libalpm/hooks" \
      hooks/{95-sbupdate.hook,50-sbupdate-remove.hook}

Unfortunately, brace extensions are not compatible with strict POSIX shells (like dash):

install: cannot stat 'hooks/{95-sbupdate.hook,50-sbupdate-remove.hook}': No such file or directory
make: *** [Makefile:14: install] Error 1

This issue can be fixed by either expanding the path manually or adding SHELL=bash.