andrii-kryvoviaz / slink

Self-hosted image sharing service.
GNU Affero General Public License v3.0
313 stars 9 forks source link

[ Feature Request ] Show the added description to the public shared link #5

Closed arpanghosh8453 closed 8 months ago

arpanghosh8453 commented 8 months ago

The added description does not show up anywhere, so I was wondering what is the use case for that. Is there any chance to add that to the public shared link page?

andrii-kryvoviaz commented 8 months ago

It should be displayed on the public page, if shared.

I'm still thinking of the use case of it. My initial idea was to create some sort of short notes for an image, which could be used for personal use, or be shared, so others could get a hint.

arpanghosh8453 commented 8 months ago

I did not see the description on the shared page, even though I added it later to the image. BTW, in the current version, once you add a description, you cannot remove it anymore. You must add something to replace it there.

andrii-kryvoviaz commented 8 months ago

Yes, it has validation applied, so an empty string won't work :) I will add and extra API enpoint to clear the description.

andrii-kryvoviaz commented 8 months ago

I tied to set a description, for me it worked indeed.

image

Not sure, why it might not work for you. Will take a look at it later.

arpanghosh8453 commented 8 months ago

I mean, not on the public discover page, I was referring to the link we get to share individual image.

andrii-kryvoviaz commented 8 months ago

Yep, they are just raw images ready to be embedded as is.

As I see it now, there should be a completely different process for sharing, which will lead to the info page with limited permissions, lets say only to read. So, a user can decide what to share for each use case.

arpanghosh8453 commented 8 months ago

I see, that makes sense. Maybe you can give two different URLs for different purposes.

andrii-kryvoviaz commented 8 months ago

Closely related to #7 as a part of an advanced image sharing strategy.