andriusvelykis / isabelle-eclipse

Eclipse integration for Isabelle proof assistant.
http://andriusvelykis.github.io/isabelle-eclipse
Eclipse Public License 1.0
12 stars 4 forks source link

Symbol line height not rescaled #45

Closed makarius closed 11 years ago

makarius commented 11 years ago

The "Symbol" window does not adjust its line height when the font size is scaled up/down. This means symbols become invisible for large font size.

andriusvelykis commented 11 years ago

This is interesting - it does work on Mac OS X and Windows. When Isabelle font is resized (either in Preferences or via toolbar buttons), the line height in symbols view changes as well immediately - see screenshot.

From what I understand, you have encountered this problem on Linux (I have not tested it on Linux yet)?

symbols-large

makarius commented 11 years ago

Yes, using the Linux GTK version on Xubuntu 12.04 LTS x86_64. Each line would be approximately half-height compared to the above picture.

andriusvelykis commented 11 years ago

OK, I can reproduce this on Linux. Will look into it.

andriusvelykis commented 11 years ago

An attempt to get this working is in 3320b656f21a9d271f211e9f7a4ab968695ede54

The row height issue on SWT is problematic (see SWT bugs 154341 and 148039).

This change does seem to achieve the wanted effect on Linux - the rows are resized correctly. I have checked it on on Ubuntu 12.10, 32-bit, GTK 2.24.13-0ubuntu2, I think.

Since there is no official API, I cannot be sure it works everywhere though. I would appreciate if you could check it on your machine.

The latest nightly build has the change now.

symbols-view-large-linux

makarius commented 11 years ago

OK, it looks the same as in the second picture.

andriusvelykis commented 11 years ago

Good to hear - closing the issue then.