search

andriusvelykis / reflow-maven-skin

Reflow is an Apache Maven site skin built on Bootstrap. It allows various structural and stylistic customizations to create a modern-looking Maven-generated website.
http://andriusvelykis.github.io/reflow-maven-skin/
Apache License 2.0
132 stars 54 forks source link

introduce a hightlightJsVersion variable in the config to control highli... #17

Closed romain-grecourt closed 10 years ago

romain-grecourt commented 10 years ago

Had some issue with Java syntax highligths when using generics, see https://hk2.java.net/2.2.0-b24/custom-resolver-example.html. Figured that version 7.5 fixes the issue.

However only this is hardcoded currently and only one version of the reflow maven skin is published. This change is about exposing highlightjs's version to configuration in site.xml.

buildhive commented 10 years ago

Andrius Velykis » reflow-maven-skin #13 SUCCESS This pull request looks good (what's this?)

andriusvelykis commented 10 years ago

Thanks for reporting and the changes!

It is unfortunate that I have fallen behind with the versions - the solution does look future-proof in regards to the future releases of highlightJs.

I will merge this soon. I guess then it will become available as the -SNAPSHOT release, but I hoped to get more issues fixed for the next proper release. Would -SNAPSHOTS be enough for now?

romain-grecourt commented 10 years ago

I can't use SNAPSHOT as this is hooked into our release process (SNAPSHOTs are forbidden :( ) . Would you consider doing a micro release ? such as 1.0.1 ?

andriusvelykis commented 10 years ago

I think I will do a small release then. I will also try to bump other library versions and include the local resource option (e.g. #18).

Furthermore, while thinking about solution for #18, I am leaning away from adding additional configuration flags. For convenience, I would try to keep up to date with all the new releases, but the versions would be hard-coded for simplicity.

For any other customisations, there is the decoration.head configuration element. It allows arbitrary HTML and can be used to include your own CSS/JavaScript. It also supports Velocity variables, so provides a solution for such problems. Please see my reply in #18.

What do you think? Would this work for your use case?

romain-grecourt commented 10 years ago

I'm fine with #18. Any ETA regarding the release ?

andriusvelykis commented 10 years ago

Sorry - I will try to do the release asap.

andriusvelykis commented 10 years ago

Fixed as discussed - see #24.

Closing the pull request.

andriusvelykis commented 10 years ago

Done - released 1.1.0 :)

romain-grecourt commented 10 years ago

Thanks, trying now !