search

andriusvelykis / reflow-maven-skin

Reflow is an Apache Maven site skin built on Bootstrap. It allows various structural and stylistic customizations to create a modern-looking Maven-generated website.
http://andriusvelykis.github.io/reflow-maven-skin/
Apache License 2.0
132 stars 54 forks source link

Skin does not work with Maven Site Plugin 3.5 #49

Open bindul opened 8 years ago

bindul commented 8 years ago

The changes introduced in Maven Site Plugin breaks the skin. Maven Site 3.5 introduced some non backward compatible changes From 3.4 to 3.5

Among other issues, the body is rendered as:

<div class="body-content">
$bodyWithHeader
</div>
Bernardo-MG commented 8 years ago

The root problem is that the new Maven Site plugin is not loading Velocity tools.

See: http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html

marvec commented 8 years ago

I am experiencing the same issue and a fix would be highly appreciated.

Bernardo-MG commented 8 years ago

As I've been completely unable to find a fix to this problem, and it seems everybody else is in the same situation, I've opened an issue for the Maven Site plugin: https://issues.apache.org/jira/browse/MSITE-782

michael-o commented 8 years ago

This issue has been fixed in https://issues.apache.org/jira/browse/DOXIASITETOOLS-168 and needs some trivial changes in this plugin.

Bernardo-MG commented 8 years ago

Thanks for the fix

solomax commented 7 years ago

Recently tried with Maven Site Plugin 3.6 and this issue is not fixed :(

bindul commented 7 years ago

@solomax, as noted above (by @michael-o):

This issue has been fixed in https://issues.apache.org/jira/browse/DOXIASITETOOLS-168 and needs some trivial changes in this plugin.

The plugin still needs a change, I believe around moving reflow-maven-skin/reflow-velocity-tools/src/main/resources/tools.xml to META-INF/maven/site-tools.xml (or moving it there during the build), as suggested in DOXIASITETOOLS-168 comment-15578066.

Have not tested.

Bernardo-MG commented 7 years ago

I've updated my own skin for working with Maven Site 3.6: https://github.com/Bernardo-MG/docs-maven-skin

As commented, from now on any custom tool should move the tools.xml file to META-INF/maven/site-tools.xml

Ordiel commented 5 years ago

Should we fork this project? @andriusvelykis does not seam to be active on this repo any more (for about 5 years now)

solomax commented 5 years ago

@Ordiel we are using this one https://github.com/devacfr/reflow-maven-skin