search

andriusvelykis / reflow-maven-skin

Reflow is an Apache Maven site skin built on Bootstrap. It allows various structural and stylistic customizations to create a modern-looking Maven-generated website.
http://andriusvelykis.github.io/reflow-maven-skin/
Apache License 2.0
133 stars 54 forks source link

Generated sites does not show properly in TLS only environments #50

Open ottlinger opened 8 years ago

ottlinger commented 8 years ago

Having generated a site with version 1.1.1 yields a broken layout if shown in a browser with httpseverywhere, since the links to

Either they should be changed to https or a configuration option could be added that allows locally downloaded versions to avoid the mix of http and https.

The following links provoke the problem:

<link href="http://netdna.bootstrapcdn.com/bootswatch/2.3.2/cosmo/bootstrap.min.css" rel="stylesheet" />
<link href="http://netdna.bootstrapcdn.com/twitter-bootstrap/2.3.1/css/bootstrap-responsive.min.css" rel="stylesheet" />
<script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script>
<script src="http://netdna.bootstrapcdn.com/twitter-bootstrap/2.3.2/js/bootstrap.min.js"></script>

Changing them to https works fine:

Which way would you prefer?

The simplest option would be to change all above links to https and provide a local copy of htlm5shim - shall I start a pull request?

Thanks

bindul commented 7 years ago

@ottlinger,

Have you looked at the local resources option, documented at http://andriusvelykis.github.io/reflow-maven-skin/skin/resources.html?

llorllale commented 7 years ago

+1

Although I was able to workaround this using protocolRelativeURLs.