andrivet / ADVi3pp

ADVi3++, an alternative and better firmware for Wanhao i3 Plus printers and clones. Fork of Marlin Firmware.
https://community.advi3pp.com
GNU General Public License v3.0
243 stars 119 forks source link

Print Settings panel changes take effect immediately #309

Closed DimitryNechaev closed 2 years ago

DimitryNechaev commented 2 years ago

Did you check that your report is not a duplicate?

Yes, I have checked and this is a new bug not previously reported.

Bug Description

When accessing print panel during print and changing temperature, it takes effect immediately. There is no difference if pressing back or confirm button, or not pressing anything.

Expected behavior

As in the previous versions, changing anything in the print settings panel would only take effect after confirming the change (right arrow in the right top corner). Pressing back arrow (left top corner) would discard the changes.

Actual behavior

When I changed temperature out of curiosity to 280 from 200 during print and cancelled, it started rasing temp immediately. I had to enter the panel and dial it back as soon as possible as heating PLA to these temps would clog and screw the print. I managed to revert when it was already over 240

Also, I experimented and found that I don't need to press cancel, it adjusts temp as soon as it changes in the panel. It writes the new number in the screen header with all info, as soon as the number changed in the panel.

Steps to Reproduce

Start printing Access the panel Change temp w/o pressing confirm or back buttons

Version of ADVi3++ Firmware

5.0.3

Printer model

Aldi Coocon Create Touch

Mods

None

Bed Leveling

No Bed Leveling

Your Slicer

Cura

Host Software

No response

Additional information & file uploads

I have checked all updates description after 5.0.3 and found no mention of this issue. Neither it is reported here in GIT. I can't check later versions as of https://github.com/andrivet/ADVi3pp/issues/307 blocking me

andrivet commented 2 years ago

This is working as expected and, as far as I remember, it was always the case. Having a immediate effect is the whole point of this screen that is only available during printing.