andrivet / ADVi3pp

ADVi3++, an alternative and better firmware for Wanhao i3 Plus printers and clones. Fork of Marlin Firmware.
https://community.advi3pp.com
GNU General Public License v3.0
244 stars 119 forks source link

Apply the setting under Settings / Beeper / Beep duration to M300 without P argument #314

Closed andrivet closed 1 year ago

andrivet commented 2 years ago

Did you check that your request is not a duplicate?

Yes, I have checked and this is a new request.

Is your request specific to your setup only or can it benefit to many people?

My request will benefit to many people.

Is your feature request related to a problem? Please describe.

This is more or less related to #297.

Describe the feature you want

Today, if you do not specify a P argument to M300, a default and arbitrary duration is played (10ms, the minimum). This a deviation from the stock firmware and is annoying for some people. On the other side, when the firmware itself is playing a tone (beeps to me more precise), it takes the duration specified under Settings / Beeper / Beep duration. This is not coherent. M300 (without argument) should also use this setting.

This setting should also be saved with a GCODE. There are two solutions:

For the moment, I prefer the second solution. It could be something like M300 P1000 D with a new D parameter that means that this is the default value to use. This could be submitted to Marlin's upstream.

Additional context

This issue follows this discussion: https://community.advi3pp.com/t/lcd-beep-functionality-still-broken-in-5-0-2-on-mk2/4081/23

Have you provided enough and precise information?

Yes, I have provided precise information in the Additional context box.

andrivet commented 1 year ago

Fixed in 5.7.0