andrivet / ADVi3pp

ADVi3++, an alternative and better firmware for Wanhao i3 Plus printers and clones. Fork of Marlin Firmware.
https://community.advi3pp.com
GNU General Public License v3.0
244 stars 119 forks source link

ADVi3++5 LCD-Panel.sketch widget LED element marked as exportable #350

Closed taligentx closed 1 month ago

taligentx commented 1 month ago

Did you check that your report is not a duplicate?

Yes, I have checked and this is a new bug not previously reported.

Bug Description

As of 5.8.0, Widgets/LED/Output is marked as exportable in ADVi3++5 LCD-Panel.sketch:

Screen Shot 2024-09-16 at 8 46 31 PM

During export, this causes the Sketch app to create the following file in its own subdirectory in the export directory: Widgets/LED/Output.png:

Screen Shot 2024-09-16 at 8 57 26 PM Screen Shot 2024-09-16 at 9 20 09 PM

No other elements in the Widgets panel are marked as exportable and do not create files in their own subdirectories - for example, there is no export PNG set for this element:

Screen Shot 2024-09-16 at 8 56 46 PM

This also causes an error message when running Scripts/create-release.sh:

WARNING: Unknown file (...)/LCD-Panel/Export/Widgets/LED/Output.png

Expected behavior

The .sketch file should not export Widgets/LED/Output.png

Actual behavior

As described.

Steps to Reproduce

Export all images from ADVi3++5 LCD-Panel.sketch

Version of ADVi3++ Firmware

5.8.0

Printer model

n/a

Mods

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Additional information & file uploads

No response

andrivet commented 1 month ago

Thank you for this very detailed bug report. I will do my best to fix this. I am not using Sketch but Lunacy, so it may be related to that.

andrivet commented 1 month ago

Fixed in 6.0.0