andriyko / sublime-robot-framework-assistant

Robot Framework plugin for Sublime Text3
MIT License
109 stars 43 forks source link

Py3 support + changes for new RBFW and SeleniumLibrary by aaltat #231

Open idxn opened 5 years ago

idxn commented 5 years ago

Move to Python3. Drop support of python2 because python2 will be end of life in the year of 2019 so it would be better to move forward.

idxn commented 5 years ago

Strange. The unittest on my windows machine has passed. I'll go checking with OSX again

aaltat commented 5 years ago

Well, it does look pretty good. There is only one failure in the Python 3.6.

@andriyko should we give him the push rights or what we should do?

aaltat commented 5 years ago

I had one comment. In some point it would be vice to fix the tests. too

idxn commented 5 years ago

Sure, i'll try to get it fixed

idxn commented 5 years ago

@andriyko @aaltat Do I need to get all the unittest fixed or just the one in py3.6 to get this pull merged?

idxn commented 5 years ago

@aaltat @andriyko I have taken a look and find my suspect. In testdata, resource file importing in 'test\resource\test_data\real_suite\resource\resource1\real_suite_resource.robot' does not exist in the project as follow:

Resource ../../resource2/real_suite_resource.robot

If it's intended to, the reason it fails on unix based system is that the order of the queue list is not the same as windows. In windows, it's like this:

[SeleniumLibrary, xxx, ../../resource2/real_suite_resource.robot]

On the other hand, in unix based system, it's like this:

[ ../../resource2/real_suite_resource.robot, xxx, SeleniumLibrary]

Currently, our implementation will raise an exception if it cannot find the file so it won't parse any files in the latter. It causes our unit test to fail. If we intends to use the test data like this for specific reason, I'll need to make the changes to continue parse the file in the queue so the test_scanner.TestScanner.test_queue_populated unittest will pass and it quite makes sense for me that the scanner should not stop a scanning process because of non-existing file.

idxn commented 5 years ago

Please ignore the first comment. It misunderstood something :( I'll take a look again.

aaltat commented 5 years ago

I am having a flu and laying in the bed. I will take a look later.

idxn commented 5 years ago

Take some rest. I'm not in rush though. I'll try to get it resolve on my own.

aaltat commented 5 years ago

Well, I am pretty happy with the changes. Although looking in to why those test fails would be good to go .