Add support for PHP8 and update tests to work with newer phpunit

andrmoel / astronomy-bundle-php

MIT License

8 stars 5 forks source link

Closed GasparMDQ closed 2 years ago

GasparMDQ commented 2 years ago

I allowed for PHP 8 to be used and upgrade PHPUnit to a version compatible with it. I had to match the return type of some of the PHPUnit functions.

GasparMDQ commented 2 years ago

This PR closes #31

mjaschen commented 2 years ago

@andrmoel Do you have any plans to merge this PR?

andrmoel commented 2 years ago

Looks good and I will merge. Sorry but I rarely use PHP atm

mjaschen commented 2 years ago

Thanks a lot!

Would you mind tagging a new version so that Packagist is able to pick up?