search

andrmuel / gr-dab

GNU Radio DAB (digital audio broadcasting) module
http://0x7.ch/code/
GNU General Public License v3.0
92 stars 39 forks source link

support Gnuradio for v3.9.0 #28

Open sergiomb2 opened 3 years ago

sergiomb2 commented 3 years ago

gr-dab FTBFS with fedora rawhide , seems is the same problem of

https://github.com/drmpeg/gr-dvbs2rx/issues/10 https://github.com/drmpeg/gr-dvbs2/issues/7

yarda commented 3 years ago

Gnuradio 3.9 is stable. It drops swig and uses pybind, so OOTs needs some changes. There is porting guide https://wiki.gnuradio.org/index.php/GNU_Radio_3.9_OOT_Module_Porting_Guide

We are trying to rebase gnuradio to 3.9 in Fedora Rawhide. I could try to do some preliminary port.

yarda commented 3 years ago

We used the following patch in Fedora / RPM Fusion downstream: https://pkgs.rpmfusion.org/cgit/free/gr-dab.git/tree/gr-dab-0.4-gnuradio39.patch It's untested and without any warranty. Todo: Fix naming (dab vs grdab) - we workaround it dirty way by using symlinks. Also fix QA tests.

elafargue commented 3 years ago

Working on the fix right now, standardizing on grdab as the module name everywhere. Note that Gnuradio 3.9 has changed quite a few APIs as well, so there will be a need to fix a couple of calls like this one:

self.conv_decode = trellis.viterbi_combined_fb(self.fsm, 774, 0, 0, 4, table, trellis.TRELLIS_EUCLIDEAN)
AttributeError: module 'gnuradio.trellis' has no attribute 'viterbi_combined_fb'

If someone is interested to help, I can push my current changes to github to collaborate, let me know

See https://github.com/elafargue/gr-dab/commits/maint-3.9 for my work so far