search

android-actions / setup-android

Android SDK setup for GitHub Actions
MIT License
191 stars 62 forks source link

Quoting the license text in CI logs #384

Closed tplive closed 9 months ago

tplive commented 1 year ago

Is it a requirement somewhere that the actual license text is quoted in the logs every single time the licenses are accepted? We have a job with 20+ parallel flavours, and this adds almost 800 lines of boilerplate in the logs, for every single flavour on every single run. Not an error, but it seems excessive and these logs go to storage and add cost.

ViliusSutkus89 commented 11 months ago

Reasonable concern. That whole license agreement is 100 kb of text. However, due to legal reasons, I am not willing to hide the license text by default. We could add an optional param to the action:

- name: Setup Android SDK
  uses: android-actions/setup-android@v3
  with:
    log-android-sdk-licenses: true (default) / false

This would be pretty straightforward to implement, a perfect starter issue for a rising GitHub Actions hacker, any takers? :)

ViliusSutkus89 commented 9 months ago

Implemented in v3.1.0. Enjoy