more robust switch actions in pgp settings

android-password-store / Android-Password-Store

Android application compatible with ZX2C4's Pass command line application

https://passwordstore.app

GNU General Public License v3.0

2.53k stars 251 forks source link

more robust switch actions in pgp settings #3148

Closed agrahn closed 1 month ago

agrahn commented 1 month ago

The PGP cache settings switches have been robustified a bit more. Now, every enable/disable action of the passphrase cache clears the same to enhance safety. This requires biom. authentification every time. If it fails (error/cancellation) the previous state is reverted to. Moreover, onClick listener is now used instead of onCheckedChange because the correct switch state is rendered immediately after the action has completed (esp. after auth cancellatiion by the user).

msfjarvis commented 1 month ago

Changes LGTM bar the stylistic nits, I'll test and merge this over the weekend.