search

android-password-store / Android-Password-Store

Android application compatible with ZX2C4's Pass command line application
https://passwordstore.app
GNU General Public License v3.0
2.53k stars 251 forks source link

add user ID input field (password creation/edit), may fix #1458 #3161

Closed agrahn closed 1 month ago

agrahn commented 1 month ago

If PW file organization is set to EncryptedUsername (work/example.org(.gpg)), the username can only be set via the "Extra content" input field, see issue #1458. This PR inserts a username input field in the PasswordCreationActivity if EncryptedUsername is set, or if the "Encrypt username" switch is switched on with the other PW file organization options.

Similarly, when editing an existing PW entry, the username input box is shown, if a username is present in the stored entry, or if EncryptedUsername is enabled in the settings.

Maybe, the PW file organization setting should be moved into the "General options", as it is not only relevant for autofill, but for the password store as a whole, e. g. when adding a new password via the "Add" button.

msfjarvis commented 1 month ago

Sorry about the lack of feedback here, I want to make some changes to the approach but I've been feeling rather overwhelmed and can't dedicate any time yet.

agrahn commented 1 month ago

I'm happy with this now, if you spot anything in my changes that you disagree with or have suggestions for, please leave a review comment or create a new PR.

Thanks a lot for improving this PR and finalising it so swiftly! Everything looks as expected and I am very satisfied.