Closed zeapo closed 6 years ago
By the way, I'm opening an appeal for the second issue also, as the icon has a CC license: https://www.iconfinder.com/icons/306924/lock_password_protect_secure_icon#size=128
Working on some ideas for the logo. I'm trying to keep the same colors so that it is still recognizable, but it looks off to me. It's meant to be the Git logo with a password box for a keyhole over a padlock. I'm not much of an artist, but I think it's a workable concept.
As for the accessibility issue, I read about the change in policy this morning, which is what lead me to this issue. Unfortunately, I am almost certain that the appeal will be rejected.
It's pretty certain that the appeal will be rejected... (For the permission)
Isn't Lastpass using the same mechanism?
Seems like #293 will come back to life :)
@zeapo Yes but dev are said the mechanism will be different in the next version.
@shgysk8zer0 I like it!
@zeapo What are the size / margin / border-radius requirements for icons?
I see icons in app/src/main/res/drawable-*dpi/ic_launcher.png
and have exported to those sizes. xxxdpi icon is missing and I can generate that if given the size that it should be.
discussions https://www.reddit.com/r/androiddev/comments/7c47mf/playstore_accessibilityservice_valid_use_cases/ https://www.reddit.com/r/Android/comments/7cfldu/google_is_threatening_to_remove_apps_with/ https://www.xda-developers.com/google-threatening-removal-accessibility-services-play-store/ https://www.reddit.com/r/Android/comments/7c4go5/is_google_play_really_going_to_suspend_all_apps/
Seems the app just has to explain prominently in description and some other places why it needs BIND_ACCESSIBILITY_SERVICE
I don't think it's enough:
Le 13 nov. 2017 12:13 AM, "Matthew Wong" notifications@github.com a écrit :
discussions https://www.reddit.com/r/androiddev/comments/7c47mf/playstore_ accessibilityservice_valid_use_cases/ https://www.reddit.com/r/Android/comments/7cfldu/google_is_threatening_to_ remove_appswith/ https://www.xda-developers.com/google-threatening-removal-accessibility- services-play-store/ https://www.reddit.com/r/Android/comments/7c4go5/is google_play_really_going_to_suspend_all_apps/
Seems the app just has to explain prominently in description and some other places why it needs BIND_ACCESSIBILITY_SERVICE
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zeapo/Android-Password-Store/issues/352#issuecomment-343776749, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQgBkHz0MgGUlC6pW7cfR_bB6_b4_bSks5s13uzgaJpZM4QabIO .
So, here's the thing... I do not have the time to make two flavors of the app... if anybody is ready to take this, then he has to do it fast ... The deadline is in 24 days or so.
Wouldn't the issue with the accessibility service be solved by using the Android O Autofill API? I don't know how difficult it would be to implement, but it would use the method officially suggested by Google for autofilling passwords.
I do understand that this would be troublesome for user with Android versions <= 7. Perhaps an acceptable method would be to use a keyboard for older versions? I understand that this would require a lot of time, though.
A plan would be to:
This way we'd have the three solutions for F-Droid and only the two last on Play Store. We still need to have two builds. Not everybody runs Oreo, and not everybody wants to replace his/her keyboard.
Wouldn't it be possible to do it all in one app by enabling autofill for Android 8+ and letting everyone else use the keyboard? Using the keyboard does not require the user to permanently change keyboards. When I was using Lastpass, I temporarily switched keyboards when I changed focus to a password field, let it fill the password for me and then switched back to my everyday keyboard. All the user has to do is to press a button in the navigation or notification bar when they want to fill a password.
We need to add an accessibility permission request. Hence we need to have an AndroidManifest without <uses-permission android:name="android.permission.BIND_ACCESSIBILITY_SERVICE" />
. Sadly Accessibility Service is not part of the <uses-feature>
functionality, so you can't make it optional :(
But if we use the Android O autofill API and a keyboard, we wouldn't need the accessibility at all :)
How about pre Ore?
Le 15 nov. 2017 6:55 AM, "kwlg" notifications@github.com a écrit :
But if we use the Android O autofill API and a keyboard, we wouldn't need the accessibility at all :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zeapo/Android-Password-Store/issues/352#issuecomment-344493692, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQgBvnHrfwvqZupTsq4YdmCFXZCfqc6ks5s2nzcgaJpZM4QabIO .
@zeapo The Keyboard ?
Then we'll have to drop the accessibility even in F-Droid and wait until someone has the time to implement the keyboard for pre-Oreo devices.
@shgysk8zer0 I like it but I think it's a little jarring. What does it look like without the lighter diamond around the stuff in the center?
For icon, here are some alternate versions. I wanted to keep the same colors at first so that it was still recognizable as being the same app.
It's OK to change the colors in a future version. We should open an issue just for that.
Of the logos proposed so far in this thread, I like this one best. The colours and design are spot on - it's simple, attractive and illustrates perfectly what the app is for.
(Although I think in an ideal world, I would rotate it 90 degrees counter-clockwise).
The red and white is the most beautifull for me.
@erayd @axac I opened issue #355 to discuss the icon.
Apparently LastPass (and other commercial password managers) are not being subjected to this change: https://blog.lastpass.com/2017/11/lastpass-android-accessibility-services.html/. While I realize they're working on implementing the autofill API, for backwards compatibility I presume the accessibility functionality will continue to work.
It's also been my experience that the autofill API doesn't work in Chrome (I switched to Android-Password-Store because of this).
Hopefully the appeal will get you somewhere.
This is probably a bit out-on-a-limb, but it might be worth looking at whether or not you really need to be (or can afford to not be) on Play store. Going F-Droid-only is certainly a viable option, and would avoid having to gut a core functionality of your app.
@dragonmaus As a user, I have a strong preference that it remain listed in the play store. F-Droid is better than nothing, but IMO listing it in both places and trying to find a resolution to Google's recent policy changes is a better path.
Apparently Google has backed down from their stance on use of the Accessibility API: https://www.androidcentral.com/google-temporarily-pauses-ban-apps-using-accessibility-services. Perhaps this could be re-enabled in the Play Store for the time being?
What's the current state of the autofill api implementation? Is someone working on it currently and is there something that I can help with? Not much of an Android developer myself but I'd be happy to help any way I can
currently I'm overwhelmed with personal stuffs... I'll be back in a month or two. until then I will not be able to look into issues or try to resolve them
On Wed, Mar 28, 2018 at 12:42 PM, Marko Korhonen notifications@github.com wrote:
What's the current state of the autofill api implementation? Is someone working on it currently and is there something that I can help with? Not much of an Android developer myself but I'd be happy to help any way I can
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zeapo/Android-Password-Store/issues/352#issuecomment-376842336, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQgBoQKzEF6gEWIaa6XpmzqHrST-9e9ks5ti2kJgaJpZM4QabIO .
-- Mohamed Zenadi
Logo work has been merged in. We can continue the discussion around Autofill in #410.
Today I've got two new issues with Google Play Store:
For the first part, I've just made an appeal, I have 30 days before the application is unpublished.
For the second one, can somebody make us a good logo? :)