search

android-rcs / rcsjta

RCS-e stack for Android with GSMA API
180 stars 74 forks source link

Wrong constraint set byte set in H264 RTP stream #199

Closed SchmitzA closed 8 years ago

SchmitzA commented 8 years ago

NativeH264EncoderParams defines profile_iop as Byte in NativeH264EncoderParams#setProfilesAndLevel. If highest bit should be set (like in 0x80 for baseline profile 1.2 0x42800C) the check <0 in line 333 prevents that. So 0x42800C announced in SDP becomes 0x42000C in RTP.

yplo6403 commented 8 years ago

Can you please provide a patch for this ?

yplo6403 commented 8 years ago

Fixed with commit 4e979f450ff7b3722c6a02d401ac0be2e40a1513