search

android / android-studio-poet

Large Android projects generator
Apache License 2.0
702 stars 85 forks source link

Fixed new ().() declarations #125

Closed borisf closed 6 years ago

borisf commented 6 years ago

On the Java top method calls there were empty "new ().()" declarations that broke the Java build

borisf commented 6 years ago

@NikitaKozlov please review

NikitaKozlov commented 6 years ago

The main issues is caused by https://github.com/android/android-studio-poet/commit/df14e253e383a36679911f8156e5bcb7e6eef002 commit. I think we should solve the core issue, not the symptoms. I will continue investigating

borisf commented 6 years ago

+1

NikitaKozlov commented 6 years ago

I don't think we should merge this. The core issue was in a different place. You can find the solution here: https://github.com/android/android-studio-poet/pull/126

borisf commented 6 years ago

Totally agree, will close it shortly